[incubator-kie-issues-1131] test migration from V7 to code generation-4 #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhitocode
changed the title
Abhitocode
force-pushed
the
incubator-kie-issues-1131-4
branch
2 times, most recently
from
78f07cc to
bfffc64
Compare
elguardian
reviewed
Jun 6, 2024
elguardian
reviewed
Jun 6, 2024
| ProcessTestHelper.registerProcessEventListener(app, listener); | ||
| CallActivitySubProcessProcess.newProcess(app); | ||
| org.kie.kogito.process.Process<CallActivityMIModel> process = CallActivityMIProcess.newProcess(app); | ||
| CallActivityMIModel model = process.createModel(); |
There was a problem hiding this comment.
need to register the subprocess
CallActivitySubProcess
There was a problem hiding this comment.
registered in line 561
elguardian
requested changes
Jun 6, 2024
Abhitocode
force-pushed
the
incubator-kie-issues-1131-4
branch
2 times, most recently
from
e232ada to
b5e3cc3
Compare
|
@Abhitocode plz rebase and fix conflicts |
Abhitocode
force-pushed
the
incubator-kie-issues-1131-4
branch
from
b5e3cc3 to
6bc2abe
Compare
martinweiler
approved these changes
Jun 11, 2024
Abhitocode
force-pushed
the
incubator-kie-issues-1131-4
branch
from
6bc2abe to
0271bcd
Compare
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to previous changes associated with PRhttps://github.com//pull/3520
Migrated some BPMN processes which are being compiled using legacy v7 to code generation approach, using new branch incubator-kie-issues-1131-4
The tests can be identified by referring to Activitytest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/ActivityTest.java
Closes: apache/incubator-kie-issues#1131